lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Dec 2020 00:48:02 +0200 From: Laurent Pinchart <laurent.pinchart@...asonboard.com> To: Michal Simek <michal.simek@...inx.com> Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com, Kalyani Akula <kalyani.akula@...inx.com>, Krzysztof Kozlowski <krzk@...nel.org>, Manish Narani <manish.narani@...inx.com>, Rajan Vaja <rajan.vaja@...inx.com>, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi On Mon, Dec 07, 2020 at 12:46:56AM +0200, Laurent Pinchart wrote: > Hi Michal, > > Thank you for the patch. > > On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: > > Add label which is used by bootloader for adding bootloader specific flag. > > > > Signed-off-by: Michal Simek <michal.simek@...inx.com> > > --- > > > > U-Boot needs to add u-boot,dm-pre-reloc; property > > I'm not entirely sure what best practice rules are in this area, but > shouldn't U-Boot locate the node by name instead of label ? And regardless of what mechanism is used, it should be documented in the bindings. > > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > index 4fa820f78d76..8e9b54b5e70c 100644 > > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > > @@ -99,7 +99,7 @@ opp03 { > > }; > > }; > > > > - zynqmp_ipi { > > + zynqmp_ipi: zynqmp_ipi { > > compatible = "xlnx,zynqmp-ipi-mailbox"; > > interrupt-parent = <&gic>; > > interrupts = <0 35 4>; -- Regards, Laurent Pinchart
Powered by blists - more mailing lists