lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 Dec 2020 09:26:21 +0200 From: Leon Romanovsky <leon@...nel.org> To: Saravana Kannan <saravanak@...gle.com> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ard Biesheuvel <ardb@...nel.org>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Tomi Valkeinen <tomi.valkeinen@...com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Grygorii Strashko <grygorii.strashko@...com>, kernel-team@...roid.com, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH v2 07/17] driver core: Add fwnode_init() On Fri, Nov 20, 2020 at 06:02:22PM -0800, Saravana Kannan wrote: > There are multiple locations in the kernel where a struct fwnode_handle > is initialized. Add fwnode_init() so that we have one way of > initializing a fwnode_handle. > > Signed-off-by: Saravana Kannan <saravanak@...gle.com> > --- > drivers/acpi/property.c | 2 +- > drivers/acpi/scan.c | 2 +- > drivers/base/swnode.c | 2 +- > drivers/firmware/efi/efi-init.c | 8 ++++---- > include/linux/fwnode.h | 6 ++++++ > include/linux/of.h | 2 +- > kernel/irq/irqdomain.c | 2 +- > 7 files changed, 15 insertions(+), 9 deletions(-) In this series, I didn't find any extension of fwnode_init() to be it more than simple assignment. This change looks to me like unnecessary churn and obfuscation rather than improvement. "...ops = &...;" is pretty standard in the kernel to initialize ops structures. Thanks
Powered by blists - more mailing lists