lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 6 Dec 2020 09:31:01 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Levi Yun <ppbuk5246@...il.com>
Cc:     akpm@...ux-foundation.org, yury.norov@...il.com,
        andriy.shevchenko@...ux.intel.com,
        richard.weiyang@...ux.alibaba.com, christian.brauner@...ntu.com,
        arnd@...db.de, jpoimboe@...hat.com, changbin.du@...el.com,
        rdunlap@...radead.org, masahiroy@...nel.org, peterz@...radead.org,
        peter.enderborg@...y.com, krzk@...nel.org,
        brendanhiggins@...gle.com, keescook@...omium.org,
        broonie@...nel.org, matti.vaittinen@...rohmeurope.com,
        mhiramat@...nel.org, jpa@....mail.kapsi.fi, nivedita@...m.mit.edu,
        glider@...gle.com, orson.zhai@...soc.com,
        takahiro.akashi@...aro.org, clm@...com, josef@...icpanda.com,
        dsterba@...e.com, dushistov@...l.ru, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

On Sun, Dec 06, 2020 at 03:46:24PM +0900, Levi Yun wrote:
> Inspired find_next_*_bit and find_last_bit, add find_last_zero_bit
> And add le support about find_last_bit and find_last_zero_bit.
> 
> Signed-off-by: Levi Yun <ppbuk5246@...il.com>
> ---
>  lib/find_bit.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 62 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/find_bit.c b/lib/find_bit.c
> index 4a8751010d59..f9dda2bf7fa9 100644
> --- a/lib/find_bit.c
> +++ b/lib/find_bit.c
> @@ -90,7 +90,7 @@ unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size,
>  EXPORT_SYMBOL(find_next_zero_bit);
>  #endif
>  
> -#if !defined(find_next_and_bit)
> +#ifndef find_next_and_bit
>  unsigned long find_next_and_bit(const unsigned long *addr1,
>  		const unsigned long *addr2, unsigned long size,
>  		unsigned long offset)
> @@ -141,7 +141,7 @@ unsigned long find_last_bit(const unsigned long *addr, unsigned long size)
>  {
>  	if (size) {
>  		unsigned long val = BITMAP_LAST_WORD_MASK(size);
> -		unsigned long idx = (size-1) / BITS_PER_LONG;
> +		unsigned long idx = (size - 1) / BITS_PER_LONG;
>  
>  		do {
>  			val &= addr[idx];

This, and the change above this, are not related to this patch so you
might not want to include them.

Also, why is this patch series even needed?  I don't see a justification
for it anywhere, only "what" this patch is, not "why".

thanks

greg k-h

Powered by blists - more mailing lists