linux-kernel - Re: [PATCH] drm/amdgpu: make DRM_AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9d7e33c-4dcd-0075-d0ca-d22b2488c354@amd.com>
Date:   Mon, 7 Dec 2020 21:50:41 +0100
From:   Christian König <christian.koenig@....com>
To:     Alex Deucher <alexdeucher@...il.com>,
        Arnd Bergmann <arnd@...nel.org>
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Nathan Chancellor <natechancellor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Luben Tuikov <luben.tuikov@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Mauro Rossi <issor.oruam@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Roman Li <Roman.Li@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        Daniel Kolesa <daniel@...aforge.org>,
        Timothy Pearson <tpearson@...torengineering.com>
Subject: Re: [PATCH] drm/amdgpu: make DRM_AMD_DC x86-only again

Am 07.12.20 um 21:47 schrieb Alex Deucher:
> On Fri, Dec 4, 2020 at 3:13 AM Arnd Bergmann <arnd@...nel.org> wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> As the DRM_AMD_DC_DCN3_0 code was x86-only and fails to build on
>> arm64, merging it into DRM_AMD_DC means that the top-level symbol
>> is now x86-only as well.
>>
>> Compilation fails on arm64 with clang-12 with
>>
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3641:6: error: stack frame size of 2416 bytes in function 'dml30_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than=]
>> void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib)
>>
>> I tried to see if the stack usage can be reduced, but this is code
>> that is described as "This file is gcc-parsable HW gospel, coming
>> straight from HW engineers." and is written in a way that is inherently
>> nonportable and not meant to be understood by humans.
>>
>> There are probably no non-x86 users of this code, so simplify
>> the dependency list accordingly.
> + Daniel, Timothy
>
> Others contributed code to enable this on PPC64 and ARM64.
> Unfortunately, we don't have these platforms to test with within AMD.
> Does PPC64 have the same stack limitations as ARM64?  Harry, Leo, can
> you take a look at fixing the stack usage?

This reminds me that I wanted to reply on this.

2416 is even to much on x86 if you add -Werror :)

So this needs to be fixed anyway.

Christian.

>
> Thanks,
>
> Alex
>
>> Fixes: 20f2ffe50472 ("drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN (v3)")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>   drivers/gpu/drm/amd/display/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
>> index 797b5d4b43e5..54aa50d4deba 100644
>> --- a/drivers/gpu/drm/amd/display/Kconfig
>> +++ b/drivers/gpu/drm/amd/display/Kconfig
>> @@ -6,7 +6,7 @@ config DRM_AMD_DC
>>          bool "AMD DC - Enable new display engine"
>>          default y
>>          select SND_HDA_COMPONENT if SND_HDA_CORE
>> -       select DRM_AMD_DC_DCN if (X86 || PPC64 || (ARM64 && KERNEL_MODE_NEON)) && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS)
>> +       select DRM_AMD_DC_DCN if X86 && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS)
>>          help
>>            Choose this option if you want to use the new display engine
>>            support for AMDGPU. This adds required support for Vega and
>> --
>> 2.27.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@...ts.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Cba72f82a98a4443b0dd108d89af15c1e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C1%7C637429708726258711%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=EU1LuB3uxSCrtAw%2BgwD%2FFWsYpZMp1FbffZvkerQ7WVs%3D&amp;reserved=0