linux-kernel - Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Dec 2020 15:12:59 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Kun Yi <kunyi@...gle.com>
Subject: Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to
 dt-schema

On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote:
> Convert the Analog Devices ADM1275 bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
>  Documentation/hwmon/adm1275.rst               |  2 +-
>  3 files changed, 59 insertions(+), 26 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> new file mode 100644
> index 000000000000..2cad28c499dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@...nel.org>
> +
> +description: |
> +  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
> +  that offer digital current, voltage, and power monitoring using an on-chip,
> +  12-bit analog-to-digital converter (ADC), communicated through a PMBus
> +  compliant I2C interface.
> +
> +  Datasheets:
> +    https://www.analog.com/en/products/adm1294.html
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,adm1075
> +      - adi,adm1272
> +      - adi,adm1275
> +      - adi,adm1276
> +      - adi,adm1278
> +      - adi,adm1293
> +      - adi,adm1294
> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor-micro-ohms:
> +    description:
> +      Shunt resistor value in micro-Ohm.
> +    $ref: /schemas/types.yaml#/definitions/uint32

Don't need a type if you have units. With that dropped,

Reviewed-by: Rob Herring <robh@...nel.org>