linux-kernel - Re: [PATCH 15/22] xlink-ipc: Add xlink ipc device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207214158.GE49179@linux.intel.com>
Date:   Mon, 7 Dec 2020 13:41:58 -0800
From:   mark gross <mgross@...ux.intel.com>
To:     Rob Herring <robh@...nel.org>
Cc:     mgross@...ux.intel.com, robh+dt@...nel.org,
        leonard.crestez@....com, gregkh@...uxfoundation.org,
        palmerdabbelt@...gle.com, devicetree@...r.kernel.org,
        Ryan Carnaghi <ryan.r.carnaghi@...el.com>,
        Seamus Kelly <seamus.kelly@...el.com>, arnd@...db.de,
        damien.lemoal@....com, markgross@...nel.org, corbet@....net,
        linux-kernel@...r.kernel.org, dragan.cvetic@...inx.com,
        shawnguo@...nel.org, paul.walmsley@...ive.com, bp@...e.de,
        peng.fan@....com
Subject: Re: [PATCH 15/22] xlink-ipc: Add xlink ipc device tree bindings

On Mon, Dec 07, 2020 at 09:58:14AM -0600, Rob Herring wrote:
> On Tue, 01 Dec 2020 14:35:04 -0800, mgross@...ux.intel.com wrote:
> > From: Seamus Kelly <seamus.kelly@...el.com>
> > 
> > Add device tree bindings for the xLink IPC driver which enables xLink to
> > control and communicate with the VPU IP present on the Intel Keem Bay
> > SoC.
> > 
> > Cc: devicetree@...r.kernel.org
> > Reviewed-by: Mark Gross <mgross@...ux.intel.com>
> > Signed-off-by: Seamus Kelly <seamus.kelly@...el.com>
> > Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@...el.com>
> > ---
> >  .../misc/intel,keembay-xlink-ipc.yaml         | 49 +++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml
> > 
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml: 'additionalProperties' is a required property
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml: ignoring, error in schema: 
> warning: no schema found in file: ./Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml
> 
> 
> See https://patchwork.ozlabs.org/patch/1409186
> 
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
Thank you!  will do.

--mark