linux-kernel - RE: [PATCH] scsi: fnic: fix error return code in fnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR11MB386336068FCF398218B474CBC3CE0@BY5PR11MB3863.namprd11.prod.outlook.com>
Date:   Mon, 7 Dec 2020 23:40:05 +0000
From:   "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>,
        "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        James Bottomley <James.Bottomley@...senPartnership.com>,
        Mike Christie <michaelc@...wisc.edu>,
        Joe Eykholt <jeykholt@...co.com>,
        Abhijeet Joglekar <abjoglek@...co.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: fnic: fix error return code in fnic_probe()

Looks good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan

-----Original Message-----
From: Zhang Changzhong <zhangchangzhong@...wei.com> 
Sent: Thursday, December 3, 2020 11:48 PM
To: Satish Kharat (satishkh) <satishkh@...co.com>; Sesidhar Baddela (sebaddel) <sebaddel@...co.com>; Karan Tilak Kumar (kartilak) <kartilak@...co.com>; James E.J. Bottomley <jejb@...ux.ibm.com>; Martin K. Petersen <martin.petersen@...cle.com>; James Bottomley <James.Bottomley@...senPartnership.com>; Mike Christie <michaelc@...wisc.edu>; Joe Eykholt <jeykholt@...co.com>; Abhijeet Joglekar <abjoglek@...co.com>
Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: fnic: fix error return code in fnic_probe()

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.

Fixes: 5df6d737dd4b ("[SCSI] fnic: Add new Cisco PCI-Express FCoE HBA")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>
---
 drivers/scsi/fnic/fnic_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index 5f8a7ef..4f7befb 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -740,6 +740,7 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	for (i = 0; i < FNIC_IO_LOCKS; i++)
 		spin_lock_init(&fnic->io_req_lock[i]);
 
+	err = -ENOMEM;
 	fnic->io_req_pool = mempool_create_slab_pool(2, fnic_io_req_cache);
 	if (!fnic->io_req_pool)
 		goto err_out_free_resources;
--
2.9.5