linux-kernel - Re: [PATCH v2] phram: Allow the user to set the erase page size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Dec 2020 08:56:04 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Guohua Zhong <zhongguohua1@...wei.com>
Cc:     <richard.weinberger@...il.com>, <joern@...ybastard.org>,
        <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <nixiaoming@...wei.com>, <patrick@...motion.com>, <richard@....at>,
        <vigneshr@...com>, <wangle6@...wei.com>, <young.liuyang@...wei.com>
Subject: Re: [PATCH v2] phram: Allow the user to set the erase page size.

Hi Guohua,

Guohua Zhong <zhongguohua1@...wei.com> wrote on Mon, 7 Dec 2020
15:07:15 +0800:

> On Mon, Dec 7, 2020 at 14:56 AM Guohua Zhong <zhongguohua1@...wei.com> wrote:
> >  
> >> Permit the user to specify the erase page size as a parameter.
> >> This solves two problems:  
> >  
> >> - phram can access images made by mkfs.jffs2.  mkfs.jffs2 won't
> >> create images with erase sizes less than 8KiB; many architectures
> >> define PAGE_SIZE as 4KiB.  
> >  
> >> - Allows more effective use of small capacity devices.  JFFS2
> >> needs somewhere between 2 and 5 empty pages for garbage collection;
> >> and for an NVRAM part with only 32KiB of space, a smaller erase page
> >> allows much better utilization in applications where garbage collection
> >> is important.  
> >  
> >> Signed-off-by: Patrick O'Grady <patrick@...motion.com>
> >> Reviewed-by: Joern Engel <joern@...fs.org>
> >> Link: https://lore.kernel.org/lkml/CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@mail.gmail.com/
> >> [Guohua Zhong: fix token array index out of bounds and update patch for kernel master branch]
> >> Signed-off-by: Guohua Zhong <zhongguohua1@...wei.com>
> >> Reported-by: kernel test robot <lkp@...el.com>  
> >
> > Looks good to me, except the authorship.
> > If I understand correctly, you took this old patch and resend it.
> > Please make sure that the "From:"-Line contains the original author.
> > You can fix this up using git commit --amend --author=.
> > The git format-patch will create a correct patch.  
> 
> Sorry, I am not clear this rule before. But I found the same issue independently. It looks good 
> after changging the erase size for phram driver. Then when I try to send the patch, I found that 
> Patrick O'Grady has already send a patch which has not been merged as the link below
> https://lore.kernel.org/lkml/CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@mail.gmail.com/
> 
> So I resend a patch with some change and fix for mainline kernel with the old patch link of Patrick O'Grady.
> 
> If I need to change the authorship, I will resend this patch for V3 with authorship of Patrick O'Grady.

Yes please. Also please drop the reference to kernel test robot as you
are not fixing an issue in the kernel that the robot reported (perhaps
you had a warning from the robot about the patch itself, this is
called a review and we usually don't get credited for that, at least
not with a misleading reported-by tag).

Thanks,
Miquèl