linux-kernel - Re: [PATCH drm/hisilicon 2/2] drm/hisilicon: Delete unused local parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e08b33ab-f4b3-f23a-d5f7-56b4795875be@suse.de>
Date:   Mon, 7 Dec 2020 09:04:12 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Tian Tao <tiantao6@...ilicon.com>, airlied@...ux.ie,
        daniel@...ll.ch, kraxel@...hat.com, alexander.deucher@....com,
        tglx@...utronix.de, dri-devel@...ts.freedesktop.org,
        xinliang.liu@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH drm/hisilicon 2/2] drm/hisilicon: Delete unused local
 parameters



Am 07.12.20 um 01:49 schrieb Tian Tao:
> delete unused variable ‘priv’ to avoid warning.
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index d631f82..772f58e 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -251,12 +251,9 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
>   
>   static int hibmc_unload(struct drm_device *dev)
>   {
> -	struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
> -
>   	drm_atomic_helper_shutdown(dev);
> -
>   	pci_disable_msi(dev->pdev);
> -	dev->dev_private = NULL;
> +
>   	return 0;
>   }
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)