linux-kernel - Re: [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207105632.6ea2c7ce@xps13>
Date:   Mon, 7 Dec 2020 10:56:32 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Johan Jonker <jbx6244@...il.com>
Cc:     Yifeng Zhao <yifeng.zhao@...k-chips.com>, richard@....at,
        vigneshr@...com, robh+dt@...nel.org, devicetree@...r.kernel.org,
        heiko@...ech.de, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308,
 RK2928 and others

Hello,

Johan Jonker <jbx6244@...il.com> wrote on Sun, 6 Dec 2020 15:10:57
+0100:

> Hi Yifeng,
> 
> Meanwhile, could you post a RFC version for Uboot based on this version
> plus comments, so people can test the whole process from programming,
> booting and kernel?
> 
> On 11/30/20 1:49 PM, Johan Jonker wrote:
> > Hi,
> > 
> > Looks good to me.
> > Do the maintainers or someone else have any major issues?
> > Could Miquel indicate if a version 16 must be send for that 'ret'
> > variable alone or is it OK now?
> > 
> > 
> > On 11/30/20 11:00 AM, Yifeng Zhao wrote:  
> >> This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308,
> >> RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using
> >> 8-bit NAND interface on the ARM based RK3308 platform.  
> 
> [..]
> 
> >> +/**
> >> + * struct rk_ecc_cnt_status: represent a ecc status data.  
> 
> represent the ECC status data.

The driver looks good to me now, can you please send a v16 with the
last comments from Johan (thanks for reviewing so carefully btw!).

Thanks,
Miquèl