linux-kernel - Re: wm8960: add DAC Slope switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201207102805.GH10899@ediswmail.ad.cirrus.com>
Date:   Mon, 7 Dec 2020 10:28:05 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     "Lukas F. Hartmann" <lukas@...re.com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <patches@...nsource.cirrus.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: wm8960: add DAC Slope switch

On Tue, Nov 24, 2020 at 06:23:13PM +0100, Lukas F. Hartmann wrote:
> The WM8960 DAC has a "DAC Slope" switch that can toggle between two
> different output filter curves. This patch adds support for it.
> 
> Signed-off-by: Lukas F. Hartmann <lukas@...re.com>
> ---
> +static int wm8960_put_dacslope(struct snd_kcontrol *kcontrol,
> +			       struct snd_ctl_elem_value *ucontrol)
> +{
> +	struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
> +	struct wm8960_priv *wm8960 = snd_soc_component_get_drvdata(component);
> +	unsigned int val = ucontrol->value.integer.value[0];
> +
> +	if (val > 1)
> +		return -EINVAL;
> +
> +	wm8960->dacslope = val;
> +
> +	return snd_soc_component_update_bits(component, WM8960_DACCTL1,
> +				   0x2, val<<1);

Is the DAC Slope switch not in DACCTL2?

Thanks,
Charles