linux-kernel - Re: [PATCH pidfd] signal: Add missing __user annotation to copy_siginfo_from_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201207103230.inx52blkask3662j@wittgenstein>
Date:   Mon, 7 Dec 2020 11:32:30 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Jann Horn <jannh@...gle.com>
Cc:     Oleg Nesterov <oleg@...hat.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH pidfd] signal: Add missing __user annotation to
 copy_siginfo_from_user_any

On Mon, Dec 07, 2020 at 01:02:52AM +0100, Jann Horn wrote:
> copy_siginfo_from_user_any() takes a userspace pointer as second
> argument; annotate the parameter type accordingly.
> 
> Signed-off-by: Jann Horn <jannh@...gle.com>
> ---
> I'm messing around with clang's version of __user annotation checking
> and it spotted this issue:
> 
> kernel/signal.c:3759:44: warning: casting to dereferenceable pointer removes 'noderef' attribute [-Wnoderef]
>                 ret = copy_siginfo_from_user_any(&kinfo, info);
>                                                          ^~~~
> Untracked cast to function pointer at kernel/signal.c:4294:26
> 
> 
> Christian, since this is pidfd code, can you take this through your tree?
> Or should I send this to akpm (or someone else)?

I'm picking it up now. :) Thanks!

Christian