linux-kernel - Re: [PATCH v6 1/8] dt-bindings: display: simple: fix alphabetical order for EDT compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207110616.r47utgzdkw3wrply@pengutronix.de>
Date:   Mon, 7 Dec 2020 12:06:16 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        David Jander <david@...tonic.nl>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 1/8] dt-bindings: display: simple: fix alphabetical
 order for EDT compatibles

On Sat, Dec 05, 2020 at 08:32:29PM +0100, Sam Ravnborg wrote:
> Hi Oleksij

> Thanks for fixing this, but something is not correct.
> I think you switched around the order of comment and compatible.

Ack, i confused my self with comments like:
> > -      - edt,etm0700g0dh6
> > -        # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > -        # Same as ETM0700G0DH6 but with inverted pixel clock.
> >        - edt,etm070080bdh6

Do this comments actually make any sense? All of this devices are kind
of similar to each other.

> On Wed, Dec 02, 2020 at 09:18:19AM +0100, Oleksij Rempel wrote:
> > Reorder it alphabetically and remove one double entry.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  .../bindings/display/panel/panel-simple.yaml     | 16 +++++++---------
> >  1 file changed, 7 insertions(+), 9 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index edb53ab0d9eb..428b03342fea 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > @@ -106,26 +106,24 @@ properties:
> >          # Emerging Display Technology Corp. 3.5" QVGA TFT LCD panel
> >        - edt,et035012dm6
> >          # Emerging Display Technology Corp. 480x272 TFT Display with capacitive touch
> > +      - edt,et057090dhu
> > +        # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >        - edt,etm043080dh6gp
> >          # Emerging Display Technology Corp. 480x272 TFT Display
> >        - edt,etm0430g0dh6
> >          # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel
> > -      - edt,et057090dhu
> > -        # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > -      - edt,etm070080dh6
> > -        # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch


> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >          # Same display as the ETM0700G0BDH6, but with changed hardware for the
> >          # backlight and the touch interface.
> > +      - edt,etm070080dh6
> > +        # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >        - edt,etm070080edh6
> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >          # Same timings as the ETM0700G0DH6, but with resistive touch.
> > -      - edt,etm070080dh6
> > -        # Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > +      - edt,etm0700g0dh6
> > +        # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > +        # Same as ETM0700G0DH6 but with inverted pixel clock.
> >        - evervision,vgg804821
> >          # Foxlink Group 5" WVGA TFT LCD panel
> >        - foxlink,fl500wvr00-a0t
> 
> It goes like this
> 
> 	  # This is the comment
> 	- compatible,for-the-comment
> 
> I always look at the first entry when I need to check the order.
> Also the comment for evervision,vgg804821 seems to be lost in the above.

ack.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |