linux-kernel - Re: [PATCH v4] phram: Allow the user to set the erase page size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201207111541.8887-1-miquel.raynal@bootlin.com>
Date:   Mon,  7 Dec 2020 12:15:41 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Guohua Zhong <zhongguohua1@...wei.com>, patrick@...motion.com,
        joern@...ybastard.org, miquel.raynal@...tlin.com, richard@....at,
        vigneshr@...com
Cc:     wangle6@...wei.com, young.liuyang@...wei.com,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        nixiaoming@...wei.com
Subject: Re: [PATCH v4] phram: Allow the user to set the erase page size.

On Mon, 2020-12-07 at 09:55:29 UTC, Guohua Zhong wrote:
> From: Patrick O'Grady <patrick@...motion.com>
> 
> Permit the user to specify the erase page size as a parameter.
> This solves two problems:
> 
> - phram can access images made by mkfs.jffs2.  mkfs.jffs2 won't
> create images with erase sizes less than 8KiB; many architectures
> define PAGE_SIZE as 4KiB.
> 
> - Allows more effective use of small capacity devices.  JFFS2
> needs somewhere between 2 and 5 empty pages for garbage collection;
> and for an NVRAM part with only 32KiB of space, a smaller erase page
> allows much better utilization in applications where garbage collection
> is important.
> 
> Signed-off-by: Patrick O'Grady <patrick@...motion.com>
> Reviewed-by: Joern Engel <joern@...fs.org>
> Link: https://lore.kernel.org/lkml/CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@mail.gmail.com/
> [Guohua Zhong: fix token array index out of bounds and update patch for kernel master branch]
> Signed-off-by: Guohua Zhong <zhongguohua1@...wei.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel