linux-kernel - Re: [PATCH v2] mtd: physmap: physmap-bt1-rom: Fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon,  7 Dec 2020 12:15:58 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>
Cc:     kernel test robot <lkp@...el.com>,
        Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>,
        linux-kernel@...r.kernel.org,
        Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        linux-mtd@...ts.infradead.org,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>
Subject: Re: [PATCH v2] mtd: physmap: physmap-bt1-rom: Fix __iomem addrspace removal warning

On Wed, 2020-11-25 at 07:26:40 UTC, Serge Semin wrote:
> sparse is unhappy with us casting the __iomem address space pointer to
> a type with no address space attribute specified:
> 
> "sparse warnings: (new ones prefixed by >>)"
> >> drivers/mtd/maps/physmap-bt1-rom.c:78:18: sparse: sparse: cast removes address space '__iomem' of expression
> 
> Indeed we perform the __iomem-less type casting but to an integer
> variable. The integer variable isn't dereferenced then, so the casting is
> safe and won't cause any problem. But in order to make sparse happy and
> keep the code coherent let's fix the warning by converting the local
> "shift" and "chunk" variables to the "unsigned int" type (since their
> value won't ever exceed three) and cast the __iomem-pointers to uintptr_t.
> Add the same fix to the bt1_rom_map_read() method for unification.
> 
> Fixes: b3e79e7682e0 ("mtd: physmap: Add Baikal-T1 physically mapped ROM support")
> Link: https://lore.kernel.org/lkml/202011021254.XC70BaQT-lkp@intel.com/
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> Cc: Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel