linux-kernel - RE: [PATCH V3 3/7] remoteproc: imx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Dec 2020 02:08:29 +0000
From:   Peng Fan <peng.fan@....com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>
CC:     "ohad@...ery.com" <ohad@...ery.com>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Zhu <hongxing.zhu@....com>
Subject: RE: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message

> Subject: Re: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message
> 
> On Fri 04 Dec 01:40 CST 2020, Peng Fan (OSS) wrote:
> 
> > From: Peng Fan <peng.fan@....com>
> >
> > It is using devm_ioremap, so not devm_ioremap_resource. Correct the
> > error message and print out sa/size.
> >
> > Acked-by: Richard Zhu <hongxing.zhu@....com>
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index d1abb253b499..aa5fbd0c7768
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -270,7 +270,7 @@ static int imx_rproc_addr_init(struct imx_rproc
> *priv,
> >  		priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> >  						     att->sa, att->size);
> >  		if (!priv->mem[b].cpu_addr) {
> > -			dev_err(dev, "devm_ioremap_resource failed\n");
> > +			dev_err(dev, "devm_ioremap failed\n");
> 
> I would prefer if this was expanded to a proper sentence, and I really like the
> second part of the commit message to be included in the change.
> So something like:
> 
> 			dev_err(dev, "failed to remap %#x bytes from %#x\n",
> 				att->size, att->sa);
> 
> 
> And similarly below if mapping a memory-region fails.

ok, fix in v4.

Thanks,
Peng.

> 
> Thanks,
> Bjorn
> 
> >  			return -ENOMEM;
> >  		}
> >  		priv->mem[b].sys_addr = att->sa;
> > --
> > 2.28.0
> >