linux-kernel - Re: [PATCH] perf arm pmu: fix build error on MUSL libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7chU0SP79cjuZOBg1Rhe2NYaxAOnKzdQ+XQ65fenTzak0A@mail.gmail.com>
Date:   Mon, 7 Dec 2020 21:31:06 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Chanho Park <chanho61.park@...sung.com>
Cc:     Will Deacon <will@...nel.org>, Chanho Park <parkch98@...il.com>,
        mathieu.poirier@...aro.org, suzuki.poulose@....com,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        John Garry <john.garry@...wei.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jiri Olsa <jolsa@...hat.com>, Khem Raj <raj.khem@...il.com>
Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc

Hi Chanho,

On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@...sung.com> wrote:
>
> Hi Will,
>
> > Looks like other files just include this unconditionally, but have a
> > comment explaining why. See util/branch.h and util/event.h. Maybe we
> > should do the same for util/pmu.h, which is already included here?
>
> I found below files which perf includes <linux/perf_event.h>. Instead of
> doing same for all, we'd better put this only for
> tools/include/uapi/linux/perf_event.h.

It's a copy of the kernel header, I'm not sure we want to add something there.

Thanks,
Namhyung