linux-kernel - Re: [PATCH v3 4/7] regulator: Add regulator driver for ATC260x PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207133003.GC5694@sirena.org.uk>
Date:   Mon, 7 Dec 2020 13:30:03 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Cristian Ciocaltea <cristian.ciocaltea@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Andreas Färber <afaerber@...e.de>,
        linux-actions@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 4/7] regulator: Add regulator driver for ATC260x PMICs

On Sun, Dec 06, 2020 at 03:27:04AM +0200, Cristian Ciocaltea wrote:

> +/*
> + * ATC2603C notes:
> + * - LDO8 is not documented in datasheet (v2.4), but supported
> + *   in the vendor's driver implementation (xapp-le-kernel).
> + * - LDO12 mentioned in datasheet is not programmable, hence not
> + *   handled in this driver.
> + */

No reason not to include LDO12 here, the framework supports fixed
regulators fine and the bindings should reflect the physical structure
of the hardware - if something is being supplied by LDO12 on the PMIC
then you'd expect the binding showing a connection from LDO12.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)