linux-kernel - Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201207133221.GA32877@kozik-lap>
Date:   Mon, 7 Dec 2020 14:32:21 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Shengjiu Wang <shengjiu.wang@....com>
Cc:     robh+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote:
> On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote:
> > Error log:
> > sysfs: cannot create duplicate filename '/bus/platform/devices/30000000.bus'
> > 
> > The spba bus name is duplicate with aips bus name.
> > Refine spba bus name to fix this issue.
> > 
> > Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter")
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > index fd669c0f3fe5..30762eb4f0a7 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> > @@ -246,7 +246,7 @@ aips1: bus@...00000 {
> >  			#size-cells = <1>;
> >  			ranges;
> >  
> > -			spba: bus@...00000 {
> > +			spba: spba-bus@...00000 {
> 
> The proper node name is "bus" so basically you introduce wrong name to
> other problem.  Introducing wrong names at least requires a comment.

I just noticed that my message was barely understandable... so let me
fix it:

The proper node name is "bus" so basically you introduce wrong name to
_fix_ other problem.  Introducing wrong names at least requires a comment.

> However the actual problem here is not in node names but in addresses:
> 
> 	aips1: bus@...00000 {
> 		spba: bus@...00000 {
> 
> You have to devices with the same unit address. How do you share the
> address space?
> 
> I think this should be rather fixed.

And again, hungry keyboard ate a letter, so:

You have _two_ devices with the same unit address. How do you share the
address space?
I think this should be rather fixed.

Best regards,
Krzysztof