linux-kernel - Re: [PATCH] PCI: dwc: exynos: add back MSI dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1UH1O2kWOkHGAmFQ4Ys7MKBiC2OoDs96Ba4yWSf7vyTg@mail.gmail.com>
Date:   Mon, 7 Dec 2020 15:48:54 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Dilip Kota <eswara.kota@...ux.intel.com>,
        Vidya Sagar <vidyas@...dia.com>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Alex Dewar <alex.dewar90@...il.com>,
        PCI <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: dwc: exynos: add back MSI dependency

On Mon, Dec 7, 2020 at 3:23 PM Rob Herring <robh@...nel.org> wrote:
> On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann <arnd@...nel.org> wrote:
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 020101b58155..e403bb2eeb4c 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -85,6 +85,7 @@ config PCIE_DW_PLAT_EP
> >  config PCI_EXYNOS
> >         tristate "Samsung Exynos PCIe controller"
> >         depends on ARCH_EXYNOS || COMPILE_TEST
> > +       depends on PCI && PCI_MSI_IRQ_DOMAIN
>
> PCI isn't needed here.

Ah right. I had copied this from PCIE_DW_PLAT_HOST, and
I'm fairly sure it used to be needed at some point in the past,
but the Kconfig file has been changed enough over time that
it clearly is not needed any more, as the entire menu depends on
PCI nowadays, i.e. you can no longer have an endpoint-only
configuration.

      Arnd