lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Dec 2020 11:43:38 +0800 From: liulongfang <liulongfang@...wei.com> To: Herbert Xu <herbert@...dor.apana.org.au> CC: <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930 On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> @@ -211,6 +219,167 @@ struct sec_sqe { >> struct sec_sqe_type2 type2; >> }; >> >> +#pragma pack(4) > > Please don't use pragma pack. Instead add the attributes as > needed to each struct or member. > > Cheers, > Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? Thanks, Longfang.
Powered by blists - more mailing lists