linux-kernel - Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <771a76da-bdd3-54b2-3661-e9db918ee00d@redhat.com>
Date:   Mon, 7 Dec 2020 15:54:09 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Peter Kästle <peter@...e.net>,
        mgross@...ux.intel.com
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval
 value when it is set

Hi,

On 12/4/20 12:43 PM, Daniel Lezcano wrote:
> On 03/12/2020 22:22, Peter Kästle wrote:
>> 3. Dezember 2020 08:17, "Daniel Lezcano" <daniel.lezcano@...aro.org> schrieb:
>>
>>> Currently the code checks the interval value when the temperature is
>>> read which is bad for two reasons:
>>>
>>> - checking and setting the interval in the get_temp callback is
>>> inaccurate and awful, that can be done when changing the value.
>>>
>>> - Changing the thermal zone structure internals is an abuse of the
>>> exported structure, moreover no lock is taken here.
>>>
>>> The goal of this patch is to solve the first item by using the 'set'
>>> function called when changing the interval. The check is done there
>>> and removed from the get_temp function. If the thermal zone was not
>>> initialized yet, the interval is not updated in this case as that will
>>> happen in the init function when registering the thermal zone device.
>>
>> Thanks for your effort.  This improves the code, good finding.
>>
>>  
>>> I don't have any hardware to test the changes.
>>
>> Tests successfully executed on my good old AOA110.
>>
>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>>
>> Acked-by: Peter Kaestle <peter@...e.net>
> 
> Thanks for testing the changes.
> 
> Shall pick the patches through the thermal tree ?

I can take them through the drivers/platform/x86 (pdx86) tree,
but if you prefer to take them upstream through the thermal tree,
then that is fine too...

Here is my ack (as pdx86 maintainer) for taking them through
the thermal tree:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans