linux-kernel - Re: [PATCH -V7 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v9demoee.fsf@yhuang-dev.intel.com>
Date:   Mon, 07 Dec 2020 08:48:57 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     "Alejandro Colomar \(man-pages\)" <alx.manpages@...il.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        "Matthew Wilcox \(Oracle\)" <willy@...radead.org>,
        Rafael Aquini <aquini@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...hat.com>,
        Rik van Riel <riel@...riel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Michal Hocko <mhocko@...e.com>,
        David Rientjes <rientjes@...gle.com>,
        linux-api@...r.kernel.org, Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH -V7 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

Hi, Alex,

"Alejandro Colomar (man-pages)" <alx.manpages@...il.com> writes:

> Hi Huang Ying,
>
> Please, see a few fixes below.
>
> Thanks,
>
> Alex
>
> On 12/4/20 10:15 AM, Huang Ying wrote:
>> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
>> ---
>>  man2/set_mempolicy.2 | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>> 
>> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
>> index 68011eecb..fb2e6fd96 100644
>> --- a/man2/set_mempolicy.2
>> +++ b/man2/set_mempolicy.2
>> @@ -113,6 +113,15 @@ A nonempty
>>  .I nodemask
>>  specifies node IDs that are relative to the set of
>>  node IDs allowed by the process's current cpuset.
>> +.TP
>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
>> +When
>> +.I mode
>> +is MPOL_BIND, enable the Linux kernel NUMA balancing for the task if
>
> .B MPOL_BIND
>
>> +it is supported by kernel.
>> +If the flag isn't supported by Linux kernel, or is used with
>> +.I mode> +other than MPOL_BIND, return -1 and errno is set to EINVAL.
>
> .BR MPOL_BIND ,
>
> A minus sign should be escaped:
> \-1
> See man-pages(7)::STYLE GUIDE::Generating optimal glyphs)
>
> .I errno
> .BR EINVAL .
>
>>  .PP
>>  .I nodemask
>>  points to a bit mask of node IDs that contains up to
>> @@ -293,6 +302,11 @@ argument specified both
>>  .B MPOL_F_STATIC_NODES
>>  and
>>  .BR MPOL_F_RELATIVE_NODES .
>> +Or, the
>> +.B MPOL_F_NUMA_BALANCING
>> +isn't supported by the Linux kernel, or is used with
>> +.I mode
>> +other than MPOL_BIND.
>
> .BR MPOL_BIND .
>
>>  .TP
>>  .B ENOMEM
>>  Insufficient kernel memory was available.
>> 

Thanks a lot for your comments!  Will change them in the next version.

Best Regards,
Huang, Ying