linux-kernel - Re: [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a78eed2a-4c33-7e1a-88df-d92e33c74e20@redhat.com>
Date:   Mon, 7 Dec 2020 17:57:21 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux ACPI <linux-acpi@...r.kernel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Subject: Re: [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]

Hi,

On 12/7/20 5:55 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> According to Hans, all device objects where the _HID returns
> "INT3396" also have a _CID returning "PNP0D80", so the former
> need not be present in acpi_ignore_dep_ids[] any more.
> 
> Link: https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93cf05fb4877@redhat.com/
> Suggested-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Thanks, patch looks good to me. FWIW:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
> 
> On top of https://patchwork.kernel.org/project/linux-acpi/patch/3849919.JfvvSOo2yN@kreacher/
> 
> ---
>  drivers/acpi/scan.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -751,7 +751,6 @@ static bool acpi_info_matches_ids(struct
>  
>  /* List of HIDs for which we ignore matching ACPI devices, when checking _DEP lists. */
>  static const char * const acpi_ignore_dep_ids[] = {
> -	"INT3396", /* Windows System Power Management Controller */
>  	"PNP0D80", /* Windows-compatible System Power Management Controller */
>  	NULL
>  };
> 
> 
>