[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201207044749.GB8403@vkoul-mobl>
Date: Mon, 7 Dec 2020 10:17:49 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
alsa-devel@...a-project.org, tiwai@...e.de,
linux-kernel@...r.kernel.org, ranjani.sridharan@...ux.intel.com,
hui.wang@...onical.com, broonie@...nel.org,
srinivas.kandagatla@...aro.org, jank@...ence.com,
sanyog.r.kale@...el.com, rander.wang@...ux.intel.com,
bard.liao@...el.com
Subject: Re: [PATCH 5/7] regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
On 05-12-20, 17:31, Greg KH wrote:
> On Sat, Dec 05, 2020 at 08:52:50AM -0600, Pierre-Louis Bossart wrote:
> >
> > > > MODULE_DESCRIPTION("Regmap SoundWire MBQ Module");
> > > > -MODULE_LICENSE("GPL v2");
> > > > +MODULE_LICENSE("GPL");
> > >
> > > Why do you want to change this ?
> >
> > We only use MODULE_LICENSE("GPL") for new contributions since 'GPL v2' does
> > not bring any information on the license, is equivalent to 'GPL' and only
> > exists for 'historical reasons', see
> >
> > https://www.kernel.org/doc/html/latest/process/license-rules.html
> >
> >
> > “GPL” Module is licensed under GPL version 2. This does not express any
> > distinction between GPL-2.0-only or GPL-2.0-or-later. The exact license
> > information can only be determined via the license information in the
> > corresponding source files.
> >
> > “GPL v2” Same as “GPL”. It exists for historic reasons.
> >
> > We should have used 'GPL' in the initial regmap MBQ patch but didn't for
> > some reason, this change just realigns with what we intended.
> >
> > That said, this is unrelated to this no_pm patch so could be in a separate
> > one if you preferred it that way.
>
> It should be separate as it does not have anything to do with the real
> reason this patch was submitted.
Precisely, this should be a separate patch explaining the motivation
behind this change.
--
~Vinod
Powered by blists - more mailing lists