linux-kernel - Re: [RFC PATCH 1/1] mm/hugetlb: clear compound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201208185530.GJ7338@casper.infradead.org>
Date:   Tue, 8 Dec 2020 18:55:30 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Gerald Schaefer <gerald.schaefer@...ux.ibm.com>
Cc:     Mike Kravetz <mike.kravetz@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>
Subject: Re: [RFC PATCH 1/1] mm/hugetlb: clear compound_nr before freeing
 gigantic pages

On Tue, Dec 08, 2020 at 07:28:13PM +0100, Gerald Schaefer wrote:
> This is because only the compound_order is cleared in
> destroy_compound_gigantic_page(), and compound_nr is set to 1U << order == 1
> for order 0 in set_compound_order(page, 0).

I didn't realise there was a separate destroy path for gigantic pages.
Thanks for catching and fixing this.

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>