linux-kernel - [PATCH -next] usb: cdns3: fix build when PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue,  8 Dec 2020 11:55:35 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Peter Chen <peter.chen@....com>,
        Pawel Laszczak <pawell@...ence.com>,
        Roger Quadros <rogerq@...com>, linux-usb@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: [PATCH -next] usb: cdns3: fix build when PM_SLEEP is not set

Fix build error when CONFIG_PM_SLEEP is not enabled by adding
stubs for the PM_SLEEP functions.

../drivers/usb/cdns3/cdns3-plat.c: In function ‘cdns3_controller_resume’:
../drivers/usb/cdns3/cdns3-plat.c:246:2: error: implicit declaration of function ‘cdns_resume’; did you mean ‘cdns_remove’? [-Werror=implicit-function-declaration]
  cdns_resume(cdns, !PMSG_IS_AUTO(msg));
  ^~~~~~~~~~~

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Peter Chen <peter.chen@....com>
Cc: Pawel Laszczak <pawell@...ence.com>
Cc: Roger Quadros <rogerq@...com>
Cc: linux-usb@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/usb/cdns3/core.h |    5 +++++
 1 file changed, 5 insertions(+)

--- linux-next-20201208.orig/drivers/usb/cdns3/core.h
+++ linux-next-20201208/drivers/usb/cdns3/core.h
@@ -127,5 +127,10 @@ int cdns_remove(struct cdns *cdns);
 #ifdef CONFIG_PM_SLEEP
 int cdns_resume(struct cdns *cdns, u8 set_active);
 int cdns_suspend(struct cdns *cdns);
+#else /* CONFIG_PM_SLEEP */
+static inline int cdns_resume(struct cdns *cdns, u8 set_active)
+{ return 0; }
+static inline int cdns_suspend(struct cdns *cdns)
+{ return 0; }
 #endif /* CONFIG_PM_SLEEP */
 #endif /* __LINUX_CDNS3_CORE_H */