linux-kernel - Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201208112226.1bb31229@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Tue, 8 Dec 2020 11:22:26 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     <saeedm@...dia.com>, <leon@...nel.org>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] net/mlx5_core: remove unused including
 <generated/utsrelease.h>

On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote:
> Remove including <generated/utsrelease.h> that don't need it.
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 989c70c..82ecc161 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -30,7 +30,6 @@
>   * SOFTWARE.
>   */
>  
> -#include <generated/utsrelease.h>
>  #include <linux/mlx5/fs.h>
>  #include <net/switchdev.h>
>  #include <net/pkt_cls.h>


drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_rep_get_drvinfo’:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’ undeclared (first use in this function); did you mean ‘CSS_RELEASED’?
   66 |  strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
      |                            ^~~~~~~~~~~
      |                            CSS_RELEASED
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each undeclared identifier is reported only once for each function it appears in
make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error 1
make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2
make[4]: *** [drivers/net/ethernet/mellanox] Error 2
make[3]: *** [drivers/net/ethernet] Error 2
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [__sub-make] Error 2