linux-kernel - Re: [PATCH v4] PM: domains: create debugfs nodes when adding power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X8/ZM7Vm/aD9FdlG@kroah.com>
Date:   Tue, 8 Dec 2020 20:51:15 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Thierry Strudel <tstrudel@...gle.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Kevin Hilman <khilman@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] PM: domains: create debugfs nodes when adding power
 domains

On Tue, Dec 08, 2020 at 11:19:55AM -0800, Thierry Strudel wrote:
> debugfs nodes were created in genpd_debug_init alled in late_initcall
> preventing power domains registered though loadable modules to have
> a debugfs entry.
> 
> Create/remove debugfs nodes when the power domain is added/removed
> to/from the internal gpd_list.
> 
> Signed-off-by: Thierry Strudel <tstrudel@...gle.com>
> Change-Id: I8a2e0616746afe2a6bbd9c24bc3a0eaa84725a75

You don't need this, checkpatch.pl should have warned you :)

> ---
> v2: fix forward declaration and genpd_debugfs_dir being NULL - Ulf
> v3: remove extra trailing char added by mistake in v2 - kernel test robot
> v4: cleanup includes and regroup CONFIG_DEBUG_FS CPP blocks - Greg
>  drivers/base/power/domain.c | 73 +++++++++++++++++++++++--------------
>  1 file changed, 45 insertions(+), 28 deletions(-)

Looks good to me, thanks for fixing it up.  Rafael, will this go through
your tree?

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>