linux-kernel - Re: memory leak in generic_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1093804.1607469696@warthog.procyon.org.uk>
Date:   Tue, 08 Dec 2020 23:21:36 +0000
From:   David Howells <dhowells@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     dhowells@...hat.com,
        syzbot <syzbot+86dc6632faaca40133ab@...kaller.appspotmail.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, viro@...iv.linux.org.uk
Subject: Re: memory leak in generic_parse_monolithic [+PATCH]

Randy Dunlap <rdunlap@...radead.org> wrote:

> Here's the syzbot reproducer:
> https://syzkaller.appspot.com/x/repro.c?x=129ca3d6500000
> 
> The "interesting" mount params are:
> 	source=%^]$[+%](${:\017k[)-:,source=%^]$[+.](%{:\017\200[)-:,\000
> 
> There is no other AFS activity: nothing mounted, no cells known (or
> whatever that is), etc.
> 
> I don't recall if the mount was successful and I can't test it just now.
> My laptop is mucked up.
> 
> 
> Be aware that this report could just be a false positive: it waits
> for 5 seconds then looks for a memleak. AFAIK, it's possible that the "leaked"
> memory is still in valid use and will be freed some day.

Bah.  Multiple source= parameters.  I don't reject the second one, but just
overwrite fc->source.

David