linux-kernel - Re: [PATCH 3/4] dt-bindings: hwmon: convert TI ADS7828 bindings to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201208001637.GA59306@roeck-us.net>
Date:   Mon, 7 Dec 2020 16:16:37 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Kun Yi <kunyi@...gle.com>
Subject: Re: [PATCH 3/4] dt-bindings: hwmon: convert TI ADS7828 bindings to
 dt-schema

On Tue, Nov 17, 2020 at 11:08:06PM +0100, Krzysztof Kozlowski wrote:
> Convert the TI ADS7828 bindings to dt-schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Rob Herring <robh@...nel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ads7828.txt     | 25 --------
>  .../devicetree/bindings/hwmon/ti,ads7828.yaml | 57 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  4 --
>  3 files changed, 57 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ads7828.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ads7828.txt b/Documentation/devicetree/bindings/hwmon/ads7828.txt
> deleted file mode 100644
> index fe0cc4ad7ea9..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ads7828.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -ads7828 properties
> -
> -Required properties:
> -- compatible: Should be one of
> -	       ti,ads7828
> -	       ti,ads7830
> -- reg: I2C address
> -
> -Optional properties:
> -
> -- ti,differential-input
> -  Set to use the device in differential mode.
> -- vref-supply
> -  The external reference on the device is set to this regulators output. If it
> -  does not exists the internal reference will be used and output by the ads78xx
> -  on the "external vref" pin.
> -
> -  Example ADS7828 node:
> -
> -  ads7828: ads@48 {
> -	   comatible = "ti,ads7828";
> -	   reg = <0x48>;
> -	   vref-supply = <&vref>;
> -	   ti,differential-input;
> -  };
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml b/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> new file mode 100644
> index 000000000000..33ee575bb09d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ads7828.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/ti,ads7828.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS7828/ADS7830 Analog to Digital Converter (ADC)
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@...nel.org>
> +
> +description: |
> +  The ADS7828 is 12-Bit, 8-Channel Sampling Analog to Digital Converter (ADC)
> +  with an I2C interface.
> +
> +  Datasheets:
> +    https://www.ti.com/product/ADS7828
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ads7828
> +      - ti,ads7830
> +
> +  reg:
> +    maxItems: 1
> +
> +  ti,differential-input:
> +    description:
> +      Set to use the device in differential mode.
> +    type: boolean
> +
> +  vref-supply:
> +    description:
> +      The regulator to use as an external reference. If it does not exists the
> +      internal reference will be used.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@48 {
> +            comatible = "ti,ads7828";
> +            reg = <0x48>;
> +            vref-supply = <&vref>;
> +            ti,differential-input;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ab623ba930d5..1b1fa0424539 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -350,10 +350,6 @@ properties:
>            - st,24c256
>              # Ambient Light Sensor with SMBUS/Two Wire Serial Interface
>            - taos,tsl2550
> -            # 8-Channels, 12-bit ADC
> -          - ti,ads7828
> -            # 8-Channels, 8-bit ADC
> -          - ti,ads7830
>              # Temperature Monitoring and Fan Control
>            - ti,amc6821
>              # Temperature sensor with 2-wire interface