linux-kernel - Re: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or remote side of bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Dec 2020 10:16:46 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     "Jiang, Dave" <dave.jiang@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Arnd Bergmann <arnd@...db.de>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>,
        Tom Joseph <tjoseph@...ence.com>, Rob Herring <robh@...nel.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>
Subject: Re: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local
 or remote side of bridge

Hi Dave,

On 07/12/20 9:25 pm, Jiang, Dave wrote:
> 
> 
>> -----Original Message-----
>> From: Kishon Vijay Abraham I <kishon@...com>
>> Sent: Wednesday, November 11, 2020 8:36 AM
>> To: Bjorn Helgaas <bhelgaas@...gle.com>; Jonathan Corbet
>> <corbet@....net>; Kishon Vijay Abraham I <kishon@...com>; Lorenzo
>> Pieralisi <lorenzo.pieralisi@....com>; Arnd Bergmann <arnd@...db.de>;
>> Jon Mason <jdmason@...zu.us>; Jiang, Dave <dave.jiang@...el.com>;
>> Allen Hubbe <allenbh@...il.com>; Tom Joseph <tjoseph@...ence.com>;
>> Rob Herring <robh@...nel.org>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; linux-
>> pci@...r.kernel.org; linux-doc@...r.kernel.org; linux-
>> kernel@...r.kernel.org; linux-ntb@...glegroups.com
>> Subject: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or
>> remote side of bridge
>>
>> Invoke ntb_link_enable() to enable the NTB/PCIe link on the local or remote
>> side of the bridge.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>> ---
>>  drivers/ntb/test/ntb_tool.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c index
>> b7bf3f863d79..8230ced503e3 100644
>> --- a/drivers/ntb/test/ntb_tool.c
>> +++ b/drivers/ntb/test/ntb_tool.c
>> @@ -1638,6 +1638,7 @@ static int tool_probe(struct ntb_client *self, struct
>> ntb_dev *ntb)
>>
>>  	tool_setup_dbgfs(tc);
>>
>> +	ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);
> 
> The tool expects the user to enable the link via debugfs according to documentation. Is this necessary?

right, it can be enabled using debugfs. Will drop this patch.

Thank You,
Kishon