linux-kernel - RE: [PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on not-supported SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000701d6cd26$e82ad1e0$b88075a0$@samsung.com>
Date:   Tue, 8 Dec 2020 11:26:17 +0530
From:   "Pankaj Dubey" <pankaj.dubey@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc:     "'Sylwester Nawrocki'" <snawrocki@...nel.org>,
        "'Marek Szyprowski'" <m.szyprowski@...sung.com>,
        "'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@...sung.com>,
        "'Arnd Bergmann'" <arnd@...db.de>,
        "'Chanwoo Choi'" <cw00.choi@...sung.com>,
        "'Alim Akhtar'" <alim.akhtar@...sung.com>, <stable@...r.kernel.org>
Subject: RE: [PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on
 not-supported SoCs



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Tuesday, December 8, 2020 12:35 AM
> To: Krzysztof Kozlowski <krzk@...nel.org>; linux-arm-
> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Sylwester Nawrocki <snawrocki@...nel.org>; Marek Szyprowski
> <m.szyprowski@...sung.com>; Bartlomiej Zolnierkiewicz
> <b.zolnierkie@...sung.com>; Arnd Bergmann <arnd@...db.de>; Chanwoo
> Choi <cw00.choi@...sung.com>; Alim Akhtar <alim.akhtar@...sung.com>;
> Pankaj Dubey <pankaj.dubey@...sung.com>; stable@...r.kernel.org
> Subject: [PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on
not-
> supported SoCs
> 
> From: Marek Szyprowski <m.szyprowski@...sung.com>
> 
> Check if the SoC is really supported before gathering the needed
resources.
> This fixes endless deferred probe on some SoCs other than
> Exynos5422 (like Exynos5410).
> 
> Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage
> driver")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/soc/samsung/exynos-asv.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/soc/samsung/exynos-asv.c
> b/drivers/soc/samsung/exynos-asv.c
> index 8abf4dfaa5c5..f653e3533f0f 100644
> --- a/drivers/soc/samsung/exynos-asv.c
> +++ b/drivers/soc/samsung/exynos-asv.c
> @@ -119,11 +119,6 @@ static int exynos_asv_probe(struct platform_device
> *pdev)
>  	u32 product_id = 0;
>  	int ret, i;
> 
> -	cpu_dev = get_cpu_device(0);
> -	ret = dev_pm_opp_get_opp_count(cpu_dev);
> -	if (ret < 0)
> -		return -EPROBE_DEFER;
> -
>  	asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL);
>  	if (!asv)
>  		return -ENOMEM;
> @@ -144,6 +139,11 @@ static int exynos_asv_probe(struct platform_device
> *pdev)
>  		return -ENODEV;
>  	}
> 
> +	cpu_dev = get_cpu_device(0);
> +	ret = dev_pm_opp_get_opp_count(cpu_dev);
> +	if (ret < 0)
> +		return -EPROBE_DEFER;
> +
>  	ret = of_property_read_u32(pdev->dev.of_node, "samsung,asv-
> bin",
>  				   &asv->of_bin);
>  	if (ret < 0)
> --
> 2.25.1

Reviewed-by: Pankaj Dubey <pankaj.dubey@...sung.com>