linux-kernel - Re: [PATCH] RDMA/restrack: update kernel documentation for ib_create_named

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201208064432.GD4430@unreal>
Date:   Tue, 8 Dec 2020 08:44:32 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] RDMA/restrack: update kernel documentation for
 ib_create_named_qp()

On Mon, Dec 07, 2020 at 06:32:55PM +0100, Lukas Bulwahn wrote:
> Commit 66f57b871efc ("RDMA/restrack: Support all QP types") extends
> ib_create_qp() to a named ib_create_named_qp(), which takes the caller's
> name as argument, but it did not add the new argument description to the
> function's kerneldoc.
>
> make htmldocs warns:
>
>   ./drivers/infiniband/core/verbs.c:1206: warning: Function parameter or
>   member 'caller' not described in 'ib_create_named_qp'
>
> Add a description for this new argument based on the description of the
> same argument in other related functions.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>