linux-kernel - RE: [PATCH] perf arm pmu: fix build error on MUSL libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001001d6cd48$303a8810$90af9830$@samsung.com>
Date:   Tue, 8 Dec 2020 18:54:58 +0900
From:   "Chanho Park" <chanho61.park@...sung.com>
To:     "'Jiri Olsa'" <jolsa@...hat.com>,
        "'Namhyung Kim'" <namhyung@...nel.org>
Cc:     "'Will Deacon'" <will@...nel.org>,
        "'Chanho Park'" <parkch98@...il.com>, <mathieu.poirier@...aro.org>,
        <suzuki.poulose@....com>, <coresight@...ts.linaro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        "'linux-kernel'" <linux-kernel@...r.kernel.org>,
        "'Mike Leach'" <mike.leach@...aro.org>,
        "'Leo Yan'" <leo.yan@...aro.org>,
        "'John Garry'" <john.garry@...wei.com>,
        "'Peter Zijlstra'" <peterz@...radead.org>,
        "'Ingo Molnar'" <mingo@...hat.com>,
        "'Arnaldo Carvalho de Melo'" <acme@...nel.org>,
        "'Mark Rutland'" <mark.rutland@....com>,
        "'Khem Raj'" <raj.khem@...il.com>
Subject: RE: [PATCH] perf arm pmu: fix build error on MUSL libc

Hi Namhyung and Jiri,

> -----Original Message-----
> From: Jiri Olsa <jolsa@...hat.com>
> Sent: Monday, December 7, 2020 10:29 PM
> To: Namhyung Kim <namhyung@...nel.org>
> Cc: Chanho Park <chanho61.park@...sung.com>; Will Deacon
<will@...nel.org>;
> Chanho Park <parkch98@...il.com>; mathieu.poirier@...aro.org;
> suzuki.poulose@....com; coresight@...ts.linaro.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel <linux-kernel@...r.kernel.org>;
> Mike Leach <mike.leach@...aro.org>; Leo Yan <leo.yan@...aro.org>; John
> Garry <john.garry@...wei.com>; Peter Zijlstra <peterz@...radead.org>; Ingo
> Molnar <mingo@...hat.com>; Arnaldo Carvalho de Melo <acme@...nel.org>;
> Mark Rutland <mark.rutland@....com>; Khem Raj <raj.khem@...il.com>
> Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
> 
> On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
> > Hi Chanho,
> >
> > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@...sung.com>
> wrote:
> > >
> > > Hi Will,
> > >
> > > > Looks like other files just include this unconditionally, but have
> > > > a comment explaining why. See util/branch.h and util/event.h.
> > > > Maybe we should do the same for util/pmu.h, which is already
> included here?
> > >
> > > I found below files which perf includes <linux/perf_event.h>.
> > > Instead of doing same for all, we'd better put this only for
> > > tools/include/uapi/linux/perf_event.h.
> >
> > It's a copy of the kernel header, I'm not sure we want to add something
> there.
> 
> right, we want to copy that directly from kernel uapi so let's not do any
> changes in here
> 

I tried to modify it from include/uapi/linux/perf_event.h but it didn't
work. And then, I found perf tool tried to refer the header from
tools/include/ directory. I should go include/uapi first and sync the change
to tools/ directory. I'll re-spin this patch.

Best Regard,
Chanho Park