linux-kernel - RE: [PATCH V4 01/10] regulator: Update DA9121 dt-bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR10MB280786E90152D183C8B52454ECCD0@AM6PR10MB2807.EURPRD10.PROD.OUTLOOK.COM>
Date:   Tue, 8 Dec 2020 10:41:57 +0000
From:   Adam Ward <Adam.Ward.opensource@...semi.com>
To:     Rob Herring <robh@...nel.org>,
        Adam Ward <Adam.Ward.opensource@...semi.com>
CC:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH V4 01/10] regulator: Update DA9121 dt-bindings

On Mon, Dec 07, 2020 at 17:58PM, Rob Herring wrote:
> > +        properties:
> > +          regulator-mode:
> > +            maxItems: 1
> > +            description: Defined in include/dt-bindings/regulator/dlg,da9121-
> regulator.h
> 
> 'regulator-mode' is defined as a property of a
> 'regulator-state-(standby|mem|disk)' child node. I don't see how you
> would use this with 'regulator-initial-mode' either.
> 
> > +
> > +          regulator-initial-mode:
> > +            maxItems: 1
> 
> 'maxItems' applies to arrays and this is not an array. What you should
> have is constraints on the values:
> 
> enum: [ 0, 1, 2, 3 ]

OK, I see better now - would this be the valid way to scope them both?

        properties:
          regulator-state-(standby|mem|disk):
          type: object

            properties:
              regulator-mode:
              enum: [ 0, 1, 2, 3 ]
              description: Defined in include/dt-bindings/regulator/dlg,da9121-regulator.h

          regulator-initial-mode:
            enum: [ 0, 1, 2, 3 ]
            description: Defined in include/dt-bindings/regulator/dlg,da9121-regulator.h

I couldn't find a precedent in regulator yaml, and it's far removed enough from what
I see in the abstract JSON-schema documentation to make relating them tricky, even
if I had sufficient familiarity with the terminology to believe I'd properly understood that!

Perhaps I'd be better off abandoning this attempt, and just having the regulator
description mention these properties/file, like the texts for act8865 and max77802 do?