linux-kernel - Re: [PATCH v2 1/1] ARM: dts: mmp2-olpc-xo-1-75: clear the warnings when make dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Dec 2020 14:58:45 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Lubomir Rintel <lkundrak@...sk>, Pavel Machek <pavel@....cz>,
        Arnd Bergmann <arnd@...db.de>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] ARM: dts: mmp2-olpc-xo-1-75: clear the warnings
 when make dtbs

On Mon, Dec 7, 2020 at 9:47 AM Zhen Lei <thunder.leizhen@...wei.com> wrote:
>
> The check_spi_bus_bridge() in scripts/dtc/checks.c requires that the node
> have "spi-slave" property must with "#address-cells = <0>" and
> "#size-cells = <0>". But currently both "#address-cells" and "#size-cells"
> properties are deleted, the corresponding default values are 2 and 1. As a
> result, the check fails and below warnings is displayed.
>
> arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \
> /soc/apb@...00000/spi@...37000: incorrect #address-cells for SPI bus
>   also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
> arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \
> /soc/apb@...00000/spi@...37000: incorrect #size-cells for SPI bus
>   also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): \
> Failed prerequisite 'spi_bus_bridge'
>
> Because the value of "#size-cells" is already defined as zero in the node
> "ssp3: spi@...37000" in arch/arm/boot/dts/mmp2.dtsi. So we only need to
> explicitly add "#address-cells = <0>" and keep "#size-cells" no change.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Right, I already sent the same patch earlier.

Lubomir, can I apply this to the fixes branch?

>  arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts
> index adde62d6fce73b9..82da44dacba7172 100644
> --- a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts
> +++ b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts
> @@ -224,7 +224,7 @@
>
>  &ssp3 {
>         /delete-property/ #address-cells;
> -       /delete-property/ #size-cells;
> +       #address-cells = <0>;
>         spi-slave;
>         status = "okay";
>         ready-gpios = <&gpio 125 GPIO_ACTIVE_HIGH>;
> --
> 1.8.3
>
>