linux-kernel - Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <194d5a3c2c0f99345454004eb81c08d94181b7d7.camel@intel.com>
Date:   Tue, 8 Dec 2020 15:22:04 +0000
From:   "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>
To:     "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "zou_wei@...wei.com" <zou_wei@...wei.com>
CC:     "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and
 mmio_range_devid_1 with static keyword

On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
> Fix the following sparse warnings:
> 
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
> warning: symbol 'mmio_range_devid_0' was not declared. Should it be
> static?
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24:
> warning: symbol 'mmio_range_devid_1' was not declared. Should it be
> static?
> 
Yesterday I sent a patch "[PATCH v2 2/3] platform/x86: ISST: Allow
configurable offset range" to fix.

Thanks,
Srinivas

> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> index 2906cfe..ff49025 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c
> @@ -20,12 +20,12 @@ struct isst_mmio_range {
>         int end;
>  };
>  
> -struct isst_mmio_range mmio_range_devid_0[] = {
> +static struct isst_mmio_range mmio_range_devid_0[] = {
>         {0x04, 0x14},
>         {0x20, 0xD0},
>  };
>  
> -struct isst_mmio_range mmio_range_devid_1[] = {
> +static struct isst_mmio_range mmio_range_devid_1[] = {
>         {0x04, 0x14},
>         {0x20, 0x11C},
>  };