linux-kernel - Re: [PATCH v1] apparmor: Remove duplicate macro list_entry_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c72b22b-4dca-8a77-4b56-f2314307e6d6@canonical.com>
Date:   Tue, 8 Dec 2020 16:18:58 -0800
From:   John Johansen <john.johansen@...onical.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH v1] apparmor: Remove duplicate macro list_entry_is_head()

On 12/8/20 2:06 AM, Andy Shevchenko wrote:
> Strangely I hadn't had noticed the existence of the list_entry_is_head() in
> apparmor code when added the same one in the list.h. Luckily it's fully
> identical and didn't break builds. In any case we don't need a duplicate
> anymore, thus remove it from apparmor code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

oh nice,

I will pull into the apparmor tree

Acked-by: John Johansen <john.johansen@...onical.com>

> ---
>  security/apparmor/apparmorfs.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
> index 5fd4a64e431f..f95c6bfa8b8e 100644
> --- a/security/apparmor/apparmorfs.c
> +++ b/security/apparmor/apparmorfs.c
> @@ -2046,9 +2046,6 @@ int __aafs_ns_mkdir(struct aa_ns *ns, struct dentry *parent, const char *name,
>  	return error;
>  }
>  
> -
> -#define list_entry_is_head(pos, head, member) (&pos->member == (head))
> -
>  /**
>   * __next_ns - find the next namespace to list
>   * @root: root namespace to stop search at (NOT NULL)
>