linux-kernel - Re: [GIT PULL] IOMMU fix for 5.10 (-final)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wg370+69ZoXFdUABwwqNaej3hrjcqAsb56J++h2oXKJpg@mail.gmail.com>
Date:   Wed, 9 Dec 2020 11:17:56 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jerry Snitselaar <jsnitsel@...hat.com>
Cc:     Will Deacon <will@...nel.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Robin Murphy <robin.murphy@....com>,
        iommu <iommu@...ts.linux-foundation.org>
Subject: Re: [GIT PULL] IOMMU fix for 5.10 (-final)

On Wed, Dec 9, 2020 at 11:12 AM Jerry Snitselaar <jsnitsel@...hat.com> wrote:
>
> Since the field in the device table entry format expects it to be n
> where there are 2^n entries in the table I guess it should be:
>
> #define DTE_IRQ_TABLE_LEN 9
> #define MAX_IRQS_PER_TABLE (1 << DTE_IRQ_TABLE_LEN)

No, that "DTE_IRQ_TABLE_LEN" is not the size shift - it's the size
shift value in that DTE field, which is shifted up by 1.

That's why the current code does that

   #define DTE_IRQ_TABLE_LEN       (9ULL << 1)

there..

Which was why I suggested that new #define that is the *actual* shift
value, and then the DTE thing and the MAX_IRQS_PER_TABLE values would
depend on that.

           Linus