linux-kernel - Re: [PATCH -next] usb: cdnsp: Mark cdnsp_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201209023958.GB995@b29397-desktop>
Date:   Wed, 9 Dec 2020 02:40:28 +0000
From:   Peter Chen <peter.chen@....com>
To:     Zou Wei <zou_wei@...wei.com>
CC:     "pawell@...ence.com" <pawell@...ence.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] usb: cdnsp: Mark cdnsp_gadget_ops with static
 keyword

On 20-12-08 20:30:49, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/usb/cdns3/cdnsp-gadget.c:1546:29: warning: symbol 'cdnsp_gadget_ops' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/usb/cdns3/cdnsp-gadget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c
> index 9716273..c7c5d0a 100644
> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> @@ -1543,7 +1543,7 @@ static int cdnsp_gadget_pullup(struct usb_gadget *gadget, int is_on)
>  	return 0;
>  }
>  
> -const struct usb_gadget_ops cdnsp_gadget_ops = {
> +static const struct usb_gadget_ops cdnsp_gadget_ops = {
>  	.get_frame		= cdnsp_gadget_get_frame,
>  	.wakeup			= cdnsp_gadget_wakeup,
>  	.set_selfpowered	= cdnsp_gadget_set_selfpowered,
> -- 

Applied, thanks.

-- 

Thanks,
Peter Chen