linux-kernel - RE: [PATCH -next] usb: cdns3: fix warning when USB_CDNS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DBBPR04MB7979502194410BB1AE96DF038BCC0@DBBPR04MB7979.eurprd04.prod.outlook.com>
Date:   Wed, 9 Dec 2020 02:40:58 +0000
From:   Peter Chen <peter.chen@....com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Pawel Laszczak <pawell@...ence.com>, Roger Quadros <rogerq@...com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: RE: [PATCH -next] usb: cdns3: fix warning when USB_CDNS_HOST is not
 set

 
> In file included from ../drivers/usb/cdns3/core.c:23:0:
> ../drivers/usb/cdns3/host-export.h:27:51: warning: ‘struct usb_hcd’ declared
> inside parameter list will not be visible outside of this definition or declaration
> static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>                                                    ^~~~~~~
> 

Applied both, thanks.

Peter

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Peter Chen <peter.chen@....com>
> Cc: Pawel Laszczak <pawell@...ence.com>
> Cc: Roger Quadros <rogerq@...com>
> Cc: linux-usb@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/usb/cdns3/host-export.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20201208.orig/drivers/usb/cdns3/host-export.h
> +++ linux-next-20201208/drivers/usb/cdns3/host-export.h
> @@ -9,10 +9,10 @@
>  #ifndef __LINUX_CDNS3_HOST_EXPORT
>  #define __LINUX_CDNS3_HOST_EXPORT
> 
> -#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> -
>  struct usb_hcd;
> 
> +#if IS_ENABLED(CONFIG_USB_CDNS_HOST)
> +
>  int cdns_host_init(struct cdns *cdns);
>  int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
>