linux-kernel - Re: [PATCH] mm/filemap: add static for function __add_to_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+8MBbLLcNwnegX9eA2AP8ymbbS28ivVeoQntKKsM4MfGzYw+g@mail.gmail.com>
Date:   Wed, 9 Dec 2020 12:59:12 -0800
From:   Tony Luck <tony.luck@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Justin Forbes <jmforbes@...uxtx.org>,
        bpf <bpf@...r.kernel.org>, Alex Shi <alex.shi@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Souptick Joarder <jrdr.linux@...il.com>,
        Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Josef Bacik <josef@...icpanda.com>
Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked

On Mon, Dec 7, 2020 at 4:36 PM Michal Kubecek <mkubecek@...e.cz> wrote:
> Not removal, commit 3351b16af494 ("mm/filemap: add static for function
> __add_to_page_cache_locked") made the function static which breaks the
> build in btfids phase - but it seems to happen only on some
> architectures. In our case, ppc64, ppc64le and riscv64 are broken,
> x86_64, i586 and s390x succeed. (I made a mistake above, aarch64 did not
> fail - but only because it was not built at all.)

x86_64 fails for me:

  LD      vmlinux
  BTFIDS  vmlinux
FAILED unresolved symbol __add_to_page_cache_locked
make: *** [Makefile:1170: vmlinux] Error 255