lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202012100514.x8RtR7P7-lkp@intel.com>
Date:   Thu, 10 Dec 2020 05:22:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RESEND v1 5/5] powerpc/platforms: Move files from 4xx to 44x

Hi Christophe,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on next-20201209]
[cannot apply to robh/for-next linus/master mpe/next v5.10-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-40x-Remove-40x-platforms/20201209-211628
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-m031-20201210 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/27cc6cb808696f690aaad90722175809739de5bc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christophe-Leroy/powerpc-40x-Remove-40x-platforms/20201209-211628
        git checkout 27cc6cb808696f690aaad90722175809739de5bc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/powerpc/platforms/44x/uic.c:275:13: error: no previous prototype for 'uic_init_tree' [-Werror=missing-prototypes]
     275 | void __init uic_init_tree(void)
         |             ^~~~~~~~~~~~~
>> arch/powerpc/platforms/44x/uic.c:320:14: error: no previous prototype for 'uic_get_irq' [-Werror=missing-prototypes]
     320 | unsigned int uic_get_irq(void)
         |              ^~~~~~~~~~~
   cc1: all warnings being treated as errors
--
>> arch/powerpc/platforms/44x/soc.c:193:6: error: no previous prototype for 'ppc4xx_reset_system' [-Werror=missing-prototypes]
     193 | void ppc4xx_reset_system(char *cmd)
         |      ^~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
>> arch/powerpc/platforms/44x/msi.c:109:6: error: no previous prototype for 'ppc4xx_teardown_msi_irqs' [-Werror=missing-prototypes]
     109 | void ppc4xx_teardown_msi_irqs(struct pci_dev *dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/uic_init_tree +275 arch/powerpc/platforms/44x/uic.c

e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  274  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18 @275  void __init uic_init_tree(void)
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  276  {
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  277  	struct device_node *np;
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  278  	struct uic *uic;
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  279  	const u32 *interrupts;
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  280  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  281  	/* First locate and initialize the top-level UIC */
26cb7d8bbddc83 arch/powerpc/sysdev/uic.c        Cyrill Gorcunov  2007-11-30  282  	for_each_compatible_node(np, NULL, "ibm,uic") {
12d371a69e6df9 arch/powerpc/sysdev/uic.c        Stephen Rothwell 2007-04-29  283  		interrupts = of_get_property(np, "interrupts", NULL);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  284  		if (!interrupts)
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  285  			break;
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  286  	}
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  287  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  288  	BUG_ON(!np); /* uic_init_tree() assumes there's a UIC as the
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  289  		      * top-level interrupt controller */
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  290  	primary_uic = uic_init_one(np);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  291  	if (!primary_uic)
b7c670d673d118 arch/powerpc/platforms/4xx/uic.c Rob Herring      2017-08-21  292  		panic("Unable to initialize primary UIC %pOF\n", np);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  293  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  294  	irq_set_default_host(primary_uic->irqhost);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  295  	of_node_put(np);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  296  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  297  	/* The scan again for cascaded UICs */
26cb7d8bbddc83 arch/powerpc/sysdev/uic.c        Cyrill Gorcunov  2007-11-30  298  	for_each_compatible_node(np, NULL, "ibm,uic") {
12d371a69e6df9 arch/powerpc/sysdev/uic.c        Stephen Rothwell 2007-04-29  299  		interrupts = of_get_property(np, "interrupts", NULL);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  300  		if (interrupts) {
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  301  			/* Secondary UIC */
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  302  			int cascade_virq;
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  303  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  304  			uic = uic_init_one(np);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  305  			if (! uic)
b7c670d673d118 arch/powerpc/platforms/4xx/uic.c Rob Herring      2017-08-21  306  				panic("Unable to initialize a secondary UIC %pOF\n",
b7c670d673d118 arch/powerpc/platforms/4xx/uic.c Rob Herring      2017-08-21  307  				      np);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  308  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  309  			cascade_virq = irq_of_parse_and_map(np, 0);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  310  
ec775d0e70eb6b arch/powerpc/sysdev/uic.c        Thomas Gleixner  2011-03-25  311  			irq_set_handler_data(cascade_virq, uic);
ec775d0e70eb6b arch/powerpc/sysdev/uic.c        Thomas Gleixner  2011-03-25  312  			irq_set_chained_handler(cascade_virq, uic_irq_cascade);
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  313  
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  314  			/* FIXME: setup critical cascade?? */
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  315  		}
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  316  	}
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  317  }
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18  318  
ef24ba7091517d arch/powerpc/sysdev/uic.c        Michael Ellerman 2016-09-06  319  /* Return an interrupt vector or 0 if no interrupt is pending. */
e58923ed14370e arch/powerpc/sysdev/uic.c        David Gibson     2007-04-18 @320  unsigned int uic_get_irq(void)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36177 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ