linux-kernel - RE: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB28704A7CCBAB9DF38E26EFC4ABCC0@BYAPR11MB2870.namprd11.prod.outlook.com>
Date:   Wed, 9 Dec 2020 22:36:43 +0000
From:   "Wong, Vee Khee" <vee.khee.wong@...el.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Maxime Coquelin" <mcoquelin.stm32@...il.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45
 PHY devices



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, December 10, 2020 12:09 AM
> To: Wong, Vee Khee <vee.khee.wong@...el.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> <alexandre.torgue@...com>; Jose Abreu <joabreu@...opsys.com>; David
> S . Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> Maxime Coquelin <mcoquelin.stm32@...il.com>; Voon, Weifeng
> <weifeng.voon@...el.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Ong, Boon Leong <boon.leong.ong@...el.com>;
> linux-stm32@...md-mailman.stormreply.com; linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for
> C45 PHY devices
> 
> On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote:
> > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
> > This extends the probing of C45 PHY devices on the MDIO bus.
> >
> > Signed-off-by: Wong Vee Khee <vee.khee.wong@...el.com>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > index b2a707e2ef43..9f96bb7d27db 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev)
> >  		memcpy(new_bus->irq, mdio_bus_data->irqs,
> sizeof(new_bus->irq));
> >
> >  	new_bus->name = "stmmac";
> > +	new_bus->probe_capabilities = MDIOBUS_C22_C45;
> 
> It looks like this needs to be conditional on the version. xgmax2
> supports C45. And gmac4. But other versions don't.
> 
> 	 Andrew

I will send a v2 with conditional checking for gmac4.
I do not have a xgmac2 hardware setup to test this.