linux-kernel - Re: Revert "dm raid: remove unnecessary discard limits for raid10"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03EC7F7D-DF6E-4962-BBA7-FA554509C2E5@fb.com>
Date:   Wed, 9 Dec 2020 23:14:07 +0000
From:   Song Liu <songliubraving@...com>
To:     Mike Snitzer <snitzer@...hat.com>
CC:     Jens Axboe <axboe@...nel.dk>,
        linux-raid <linux-raid@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        Matthew Ruffell <matthew.ruffell@...onical.com>,
        "Xiao Ni" <xni@...hat.com>
Subject: Re: Revert "dm raid: remove unnecessary discard limits for raid10"



> On Dec 9, 2020, at 2:36 PM, Mike Snitzer <snitzer@...hat.com> wrote:
> 
> On Wed, Dec 09 2020 at  4:58pm -0500,
> Song Liu <songliubraving@...com> wrote:
> 
>> This reverts commit f0e90b6c663a7e3b4736cb318c6c7c589f152c28.
>> 
>> Matthew Ruffell reported data corruption in raid10 due to the changes
>> in discard handling [1]. Revert these changes before we find a proper fix.
>> 
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1907262/ 
>> Cc: Matthew Ruffell <matthew.ruffell@...onical.com>
>> Cc: Xiao Ni <xni@...hat.com>
>> Cc: Mike Snitzer <snitzer@...hat.com>
>> Signed-off-by: Song Liu <songliubraving@...com>
> 
> If you're reverting all the MD code that enabled this DM change, then
> obviously the DM change must be reverted too.  But please do _not_
> separate the DM revert from the MD reverts.

Good point! I should have thought about it through. 

Thanks,
Song

[...]