lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 00:24:06 +0100 From: Andrew Lunn <andrew@...n.ch> To: Pavana Sharma <pavana.sharma@...i.com> Cc: ashkan.boldaji@...i.com, clang-built-linux@...glegroups.com, davem@...emloft.net, devicetree@...r.kernel.org, f.fainelli@...il.com, gregkh@...uxfoundation.org, kbuild-all@...ts.01.org, kuba@...nel.org, linux-kernel@...r.kernel.org, lkp@...el.com, marek.behun@....cz, netdev@...r.kernel.org, robh+dt@...nel.org, vivien.didelot@...il.com Subject: Re: [PATCH v11 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int >On Wed, Dec 09, 2020 at 03:05:17PM +1000, Pavana Sharma wrote: > Returning 0 is no more an error case with MV88E6393 family > which has serdes lane numbers 0, 9 or 10. > So with this change .serdes_get_lane will return lane number > or -errno (-ENODEV or -EOPNOTSUPP). > > Signed-off-by: Pavana Sharma <pavana.sharma@...i.com> I see here you did actually act on my comment. Thanks. But i also said: > Other than that: > > Reviewed-by: Andrew Lunn <andrew@...n.ch> Please add such tags to new versions of the patches. It then makes it easier for everybody to know the review state of the patches, which have been reviewed and deemed O.K, and which need more review. Thanks Andrew
Powered by blists - more mailing lists