linux-kernel - [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201209042408.23079-2-utkarsh.h.patel@intel.com>
Date:   Tue,  8 Dec 2020 20:24:08 -0800
From:   Utkarsh Patel <utkarsh.h.patel@...el.com>
To:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Cc:     heikki.krogerus@...ux.intel.com, pmalani@...omium.org,
        enric.balletbo@...labora.com, rajmohan.mani@...el.com,
        azhar.shaikh@...el.com, Utkarsh Patel <utkarsh.h.patel@...el.com>
Subject: [PATCH v4 1/1] usb: typec: intel_pmc_mux: Configure cable generation value for USB4

USB4 specification chapter 3 indicates that cable data rates have to be
rounded for USB4 device to operate as USB4.
With that configure cable generation value to use rounded data rates for
USB4.

Signed-off-by: Utkarsh Patel <utkarsh.h.patel@...el.com>
---
Changes in v4:
- Removed usage of tbt_mode_vdo since data rates should always be rounded
  in the case of USB4.
- Updated commit message to reflect the change.

Changes in v3:
- Moved TBT_CABLE_ROUNDED_SUPPORT assignment to the same line.

Changes in v2:
- No change.
---
 drivers/usb/typec/mux/intel_pmc_mux.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c
index e58ae8a7fefb..cf37a59ce130 100644
--- a/drivers/usb/typec/mux/intel_pmc_mux.c
+++ b/drivers/usb/typec/mux/intel_pmc_mux.c
@@ -327,6 +327,11 @@ pmc_usb_mux_usb4(struct pmc_usb_port *port, struct typec_mux_state *state)
 		fallthrough;
 	default:
 		req.mode_data |= PMC_USB_ALTMODE_ACTIVE_CABLE;
+
+		/* Configure data rate to rounded in the case of Active TBT3
+		 * and USB4 cables.
+		 */
+		req.mode_data |= PMC_USB_ALTMODE_TBT_GEN(1);
 		break;
 	}
 
-- 
2.17.1