lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 09 Dec 2020 10:40:10 +0200 From: Kalle Valo <kvalo@...eaurora.org> To: Heiner Kallweit <hkallweit1@...il.com> Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Jonathan Corbet <corbet@....net>, Jens Axboe <axboe@...nel.dk>, Viresh Kumar <vireshk@...nel.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Dan Williams <dan.j.williams@...el.com>, Vinod Koul <vkoul@...nel.org>, David Miller <davem@...emloft.net>, Lee Jones <lee.jones@...aro.org>, Ion Badulescu <ionut@...ula.org>, Jakub Kicinski <kuba@...nel.org>, Lino Sanfilippo <LinoSanfilippo@....de>, Christian Lamparter <chunkeey@...glemail.com>, Luis Chamberlain <mcgrof@...nel.org>, Adam Radford <aradford@...il.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, James Smart <james.smart@...adcom.com>, Dick Kennedy <dick.kennedy@...adcom.com>, Nilesh Javali <njavali@...vell.com>, GR-QLogic-Storage-Upstream@...vell.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Peter Chen <Peter.Chen@....com>, Felipe Balbi <balbi@...nel.org>, "lin ux-pci\@vger.kernel.org" <linux-pci@...r.kernel.org>, linux-doc@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-ide@...r.kernel.org, dmaengine@...r.kernel.org, "netdev\@vger.kernel.org" <netdev@...r.kernel.org>, linux-parisc@...r.kernel.org, linux-wireless <linux-wireless@...r.kernel.org>, SCSI development list <linux-scsi@...r.kernel.org>, linux-serial@...r.kernel.org, Linux USB Mailing List <linux-usb@...r.kernel.org> Subject: Re: [PATCH] PCI: Remove pci_try_set_mwi Heiner Kallweit <hkallweit1@...il.com> writes: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of > pci_set_mwi() have a comment that it's an optional feature. I don't > think there's much sense in this separation and the use of > __must_check. Therefore remove pci_try_set_mwi() and remove the > __must_check attribute from pci_set_mwi(). > I don't expect either function to be used in new code anyway. > > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> > --- > patch applies on top of pci/misc for v5.11 > drivers/net/wireless/intersil/p54/p54pci.c | 2 +- > .../intersil/prism54/islpci_hotplug.c | 3 +-- > .../wireless/realtek/rtl818x/rtl8180/dev.c | 2 +- For drivers/wireless: Acked-by: Kalle Valo <kvalo@...eaurora.org> -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists