lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202012091715.PPo2nZAL-lkp@intel.com>
Date:   Wed, 9 Dec 2020 17:24:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/staging/media/atomisp//pci/ia_css_firmware.h:52:29: warning:
 'struct device' declared inside parameter list will not be visible outside
 of this definition or declaration

Hi Ingo,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a68a0262abdaa251e12c53715f48e698a18ef402
commit: 13c01139b17163c9b2aa543a9c39f8bbc875b625 x86/headers: Remove APIC headers from <asm/smp.h>
date:   4 months ago
config: i386-randconfig-a003-20200826 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=13c01139b17163c9b2aa543a9c39f8bbc875b625
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 13c01139b17163c9b2aa543a9c39f8bbc875b625
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/media/atomisp//pci/ia_css_control.h:25,
                    from drivers/staging/media/atomisp//pci/ia_css.h:28,
                    from drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:24,
                    from drivers/staging/media/atomisp//pci/atomisp_compat.h:22,
                    from drivers/staging/media/atomisp/pci/mmu/sh_mmu_mrfld.c:23:
>> drivers/staging/media/atomisp//pci/ia_css_firmware.h:52:29: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
      52 | ia_css_load_firmware(struct device *dev, const struct ia_css_env *env,
         |                             ^~~~~~
   In file included from drivers/staging/media/atomisp//pci/ia_css.h:28,
                    from drivers/staging/media/atomisp//pci/atomisp_compat_css20.h:24,
                    from drivers/staging/media/atomisp//pci/atomisp_compat.h:22,
                    from drivers/staging/media/atomisp/pci/mmu/sh_mmu_mrfld.c:23:
>> drivers/staging/media/atomisp//pci/ia_css_control.h:49:24: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
      49 | int ia_css_init(struct device           *dev,
         |                        ^~~~~~

vim +52 drivers/staging/media/atomisp//pci/ia_css_firmware.h

ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  32  
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  33  /* @brief Loads the firmware
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  34   * @param[in]	env		Environment, provides functions to access the
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  35   *				environment in which the CSS code runs. This is
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  36   *				used for host side memory access and message
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  37   *				printing.
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  38   * @param[in]	fw		Firmware package containing the firmware for all
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  39   *				predefined ISP binaries.
41022d35ddf2193 drivers/staging/media/atomisp/pci/ia_css_firmware.h                  Mauro Carvalho Chehab 2020-05-28  40   * @return			Returns -EINVAL in case of any
41022d35ddf2193 drivers/staging/media/atomisp/pci/ia_css_firmware.h                  Mauro Carvalho Chehab 2020-05-28  41   *				errors and 0 otherwise.
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  42   *
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  43   * This function interprets the firmware package. All
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  44   * contents of this firmware package are copied into local data structures, so
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  45   * the fw pointer could be freed after this function completes.
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  46   *
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  47   * Rationale for this function is that it can be called before ia_css_init, and thus
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  48   * speeds up ia_css_init (ia_css_init is called each time a stream is created but the
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  49   * firmware only needs to be loaded once).
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  50   */
41022d35ddf2193 drivers/staging/media/atomisp/pci/ia_css_firmware.h                  Mauro Carvalho Chehab 2020-05-28  51  int
8568fe630066a73 drivers/staging/media/atomisp/pci/ia_css_firmware.h                  Mauro Carvalho Chehab 2020-05-07 @52  ia_css_load_firmware(struct device *dev, const struct ia_css_env *env,
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  53  		     const struct ia_css_fw  *fw);
ad85094b293e40e drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_firmware.h Mauro Carvalho Chehab 2020-04-19  54  

:::::: The code at line 52 was first introduced by commit
:::::: 8568fe630066a733456fb1ffc8e1402191d7e27c media: atomisp: print a better message when fw version is wrong

:::::: TO: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (41589 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ